Changed type of the logged indentation depth to an enum type #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BennyLi
suggested changes
May 25, 2020
| resultXml = wptInstructionService.fetchResult(job.location.wptServer, testId) | ||
| } | ||
| performanceLoggingService.logExecutionTime(DEBUG, "Handling WPT result of jobrun ${testId} of job ${job.id}", 1) { | ||
| performanceLoggingService.logExecutionTime(DEBUG, "Handling WPT result of jobrun ${testId} of job ${job.id}", IndentationDepth.ONE) { |
Contributor
There was a problem hiding this comment.
This is much easier to read and use.
| def result = null | ||
| log.debug("Try to launch job at wptserver=${wptServer} with params=${parameters}") | ||
| performanceLoggingService.logExecutionTime(DEBUG, "Launching job ${job.label}: Calling initial runtest on wptserver.", 1) { | ||
| performanceLoggingService.logExecutionTime(DEBUG, "Launching job ${job.label}: Calling initial runtest on wptserver.", PerformanceLoggingService.IndentationDepth.ONE) { |
Contributor
There was a problem hiding this comment.
Couldn't you remove the PerformanceLoggingService. part?
Contributor
There was a problem hiding this comment.
This occurs in multiple files.
Contributor
Author
There was a problem hiding this comment.
I'll change it.
BennyLi
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.