Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows raise widget example #167

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Windows raise widget example #167

merged 3 commits into from
Mar 16, 2023

Conversation

samsonwang
Copy link
Contributor

Bring widget to the front when second instance is started, this is a workaround for Windows system.

@samsonwang
Copy link
Contributor Author

The second instance should call AllowSetForegroundWindow before the first instance calls SetForegoundWindow.
The instanceStared signal is emitted once the second instance is created.
So, the second instance have to use sendMessage to notify the first instance.

Shatur
Shatur requested changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@Shatur Shatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

examples/windows_raise_widget/main.cpp Outdated Show resolved Hide resolved
Windows.md Outdated Show resolved Hide resolved
@samsonwang samsonwang requested a review from Shatur March 14, 2023 01:23
Shatur
Shatur reviewed Mar 14, 2023
View reviewed changes
Windows.md Outdated Show resolved Hide resolved
@Shatur Shatur requested a review from itay-grudev March 14, 2023 07:58
@samsonwang @Shatur
Update Windows.md
35f3cbd 
Co-authored-by: Hennadii Chernyshchyk <genaloner@gmail.com>
@itay-grudev
Copy link
Owner

Looks good to me. @Shatur I think you need to approve the changes you requested.

@itay-grudev itay-grudev merged commit 40601bf into itay-grudev:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shatur Shatur Shatur approved these changes

@itay-grudev itay-grudev itay-grudev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonwang @itay-grudev @Shatur