Fix crash when sending ack on removed connection #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At least I hope I understood the issue correctly. Seems to fix Nheko-Reborn/nheko#825. |
deepbluev7
force-pushed
the
fix-crash-on-ack
branch
from
bf1d1be
to
d276a3f
Compare
Shatur
requested changes
Nov 24, 2021
The emit might interrupt our function and causes us to return to the event loop. In that time frame the other and might close the connection, causing our connection to be removed. In that case we call writeAck on a dangling pointer, in the best case causing a crash. So lets finish our business before emitting our signal. fixes itay-grudev#138
deepbluev7
force-pushed
the
fix-crash-on-ack
branch
from
d276a3f
to
3650975
Compare
Shatur
approved these changes
Nov 24, 2021
|
@deepbluev7 Good spot. Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emit might interrupt our function and causes us to return to the
event loop. In that time frame the other and might close the connection,
causing our connection to be removed. In that case we call writeAck on a
dangling pointer, in the best case causing a crash. So lets finish our
business before emitting our signal.
fixes #138