Skip to content

Commit

Permalink
test: increase dgram ref()/unref() coverage
Browse files Browse the repository at this point in the history
This commit completes code coverage for dgram's Socket#ref() and
Socket#unref() methods.

PR-URL: nodejs#11240
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
cjihrig authored and italoacasas committed Feb 14, 2017
1 parent d9ed965 commit 2333cd3
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 4 deletions.
9 changes: 8 additions & 1 deletion test/parallel/test-dgram-ref.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
'use strict';
require('../common');
const common = require('../common');
const dgram = require('dgram');

// should not hang, see #1282
dgram.createSocket('udp4');
dgram.createSocket('udp6');

{
// Test the case of ref()'ing a socket with no handle.
const s = dgram.createSocket('udp4');

s.close(common.mustCall(() => s.ref()));
}
16 changes: 13 additions & 3 deletions test/parallel/test-dgram-unref.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,18 @@
const common = require('../common');
const dgram = require('dgram');

const s = dgram.createSocket('udp4');
s.bind();
s.unref();
{
// Test the case of unref()'ing a socket with a handle.
const s = dgram.createSocket('udp4');
s.bind();
s.unref();
}

{
// Test the case of unref()'ing a socket with no handle.
const s = dgram.createSocket('udp4');

s.close(common.mustCall(() => s.unref()));
}

setTimeout(common.mustNotCall(), 1000).unref();

0 comments on commit 2333cd3

Please sign in to comment.