Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String interpolation with f-strings #18

Merged
merged 6 commits into from
Apr 16, 2021
Merged

String interpolation with f-strings #18

merged 6 commits into from
Apr 16, 2021

Conversation

psmiraglia
Copy link
Member

@psmiraglia psmiraglia commented Apr 14, 2021 •
edited
Loading

Scope of the pull request

Move from % to f-strings. Code inspection was performed with grep

$ grep -PIrn --color "%[a-z]?" --exclude-dir=.* --include=*.py

Solved issues

Added issues

None

Tests

  • I manually tested it
  • I added unit test
  • I ran the existing unit test and they do not fail

@psmiraglia psmiraglia added the enhancement New feature or request label Apr 14, 2021
@psmiraglia psmiraglia marked this pull request as ready for review April 16, 2021 13:18
@psmiraglia psmiraglia added this to the 0.1 milestone Apr 16, 2021
@psmiraglia psmiraglia merged commit 0ba87db into italia:main Apr 16, 2021
@psmiraglia psmiraglia deleted the feat/string-interpolation-with-fstring branch April 20, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppelinux peppelinux peppelinux approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.

String interpolation with f-string
2 participants
@psmiraglia @peppelinux