Skip to content

fix: return application/problem+json when body is empty #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfabio merged 1 commit into from
Feb 12, 2026
Merged

fix: return application/problem+json when body is empty #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,24 @@ curl -X QUERY "http://localhost:3000/v1/validate" -H "Content-Type: application/
}
```

### Example error response

All error responses are returned using the `application/problem+json` media type,
in accordance with [RFC 9457](https://www.rfc-editor.org/rfc/rfc9457.html).

```http
HTTP/1.1 400 Bad Request
Content-Type: application/problem+json
```

```json
{
"title": "empty body",
"detail": "need a body to validate",
"status": 400
}
```

## Contributing

Contributing is always appreciated, see [CONTRIBUTING.md](CONTRIBUTING.md).
Expand Down
5 changes: 2 additions & 3 deletions internal/handlers/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (

"github.com/gofiber/fiber/v2"
publiccodeParser "github.com/italia/publiccode-parser-go/v5"
"github.com/italia/publiccode-validator-api/internal/common"
)

type PubliccodeymlValidatorHandler struct {
Expand Down Expand Up @@ -43,9 +44,7 @@ func (vh *PubliccodeymlValidatorHandler) Query(ctx *fiber.Ctx) error {
// }

if len(ctx.Body()) == 0 {
return ctx.Status(fiber.StatusBadRequest).JSON(fiber.Map{
"error": "empty body",
})
return common.Error(fiber.StatusBadRequest, "empty body", "need a body to validate")
}

results := make(publiccodeParser.ValidationResults, 0)
Expand Down