Open
Conversation
…request and response openid4vp endpoints
… and security in pytest with mongo
chore: purged pending presentation_definition and general performance and security in pytest with mongo
ci: radon, pip-audit, flake conf and further improvements
…ion-rev fix: openid4vp, wallet_attestation validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the documentation, integration test configurations, and test scripts to fully deprecate the legacy Presentation Exchange flow in favor of the DCQL (Duckle) flow for credential requests. It clarifies documentation, simplifies test setup, and updates sample configuration files to use
dcql_queryat the top level. Deprecated test logic and references are removed, and the integration test scripts are refactored to use the new DCQL flow.Transition to DCQL (Duckle) Flow and Deprecation of Presentation Exchange:
docs/OPENID4VP-SATOSA-BACKEND.mdanddocs/MODELS.mdis updated to state that only the DCQL (Duckle) flow is supported for credential requests, and the legacy Presentation Exchange configuration is deprecated. Configuration instructions and parameter tables are rewritten to focus ondcql_query, with examples and field descriptions. [1] [2] [3]integration_test/README.md) is revised to remove references to deprecated test scripts and clarify that all tests now use the DCQL flow withconfig.dcql_query. Test setup instructions and configuration requirements are simplified. [1] [2]Configuration and Test Script Updates:
integration_test/conf/pyeudiw_backend.yamlandintegration_test/conf/potential/wp2uc1/userdenies/pyeudiw_backend.yaml) are updated to use a top-leveldcql_queryfield (YAML multiline), replacing the previous nested or legacy configuration. Example credential requests are provided in the new format. [1] [2]cross_device_integration_test.pyscript is refactored to use the DCQL (Duckle) flow, removing legacy comments, imports, and logic. It now imports shared DCQL logic fromcommons_duckleand uses the new test data creation functions. [1] [2] [3]Miscellaneous Improvements:
.gitguardian.yamlfile is added to ignore secrets scanning in specific test configuration files.These changes ensure that the codebase and documentation are aligned with the current DCQL (Duckle) credential request flow and remove outdated logic and configuration.