-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data produced by crawler should be public #406
Labels
Comments
What do you mean by "publish them"? @sebbalex |
we could think to serve them under a static folder in webserver |
👍 |
Let's serve the public folder via nginx @sebbalex |
sebbalex
added a commit
that referenced
this issue
Oct 15, 2019
sebbalex
added a commit
that referenced
this issue
Oct 15, 2019
Data produced by crawler are statically served #406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Data produced by crawler are stored server side and CircleCI on each commit tries to rsync them to make a fresh and aligned build. When PR comes from external branch CCI doesn't set env vars for security reasons and that rsync will fail. Data are used to create page/card which are public thus we should consider to publish them too. This will allow us to have a more simplified CI pipeline and will simplify local testing too.
@alranel @libremente
The text was updated successfully, but these errors were encountered: