[DEGGAND-88] upgrade to Android sdk 33 (13) #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are flags set for backwards compatibility reasons and should be resolved Took 8 minutes
Fixes some changes required as we can no longer use resource (R) ids in switch cases Took 18 minutes
Took 3 minutes
Took 1 minute
Took 8 minutes
Took 4 minutes
Added various changes required for notifications Took 56 minutes
itachi1706
changed the title
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| private static final String R_EGG_UNLOCK_SETTING = "egg_mode_r"; | ||
|
|
||
| private void toastUp(String s) { | ||
| Toast toast = Toast.makeText(this, s, Toast.LENGTH_SHORT); | ||
| toast.show(); | ||
| } | ||
|
|
||
| private static final String TAG = "NekoR"; | ||
|
|
||
| private final ActivityResultLauncher<String> notificationPermissionLauncher = |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| @@ -35,6 +39,17 @@ private void toastUp(String s) { | |||
| toast.show(); | |||
| } | |||
|
|
|||
| private static final String TAG = "Neko"; | |||
|
|
|||
| private final ActivityResultLauncher<String> notificationPermissionLauncher = | |||
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
Took 2 minutes
Took 1 minute
Took 2 minutes
Took 26 minutes
|
Code Climate has analyzed commit 66e022f and detected 0 issues on this pull request. View more on Code Climate. |
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.