-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented a basic API handler with Volley #195
Conversation
This is a extremely basic version and is subjected to changes Part of #194
queue.add(request) | ||
} | ||
|
||
fun makePostCall(path: String, data: String, listener: ApiCallListener) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
queue.add(request) | ||
} | ||
|
||
fun makePutCall(path: String, data: String, listener: ApiCallListener) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
return queue.sequenceNumber | ||
} | ||
|
||
fun makeGetCall(path: String, listener: ApiCallListener) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
queue.add(request) | ||
} | ||
|
||
fun makeDeleteCall(path: String, listener: ApiCallListener) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
internalCallHandling(Request.Method.GET, path, null, listener) | ||
} | ||
|
||
fun makePostCall(path: String, data: String?, listener: ApiCallListener) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
internalCallHandling(Request.Method.POST, path, data, listener) | ||
} | ||
|
||
fun makePutCall(path: String, data: String?, listener: ApiCallListener) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
internalCallHandling(Request.Method.PUT, path, data, listener) | ||
} | ||
|
||
fun makeDeleteCall(path: String, listener: ApiCallListener) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
internalCallHandling(Request.Method.GET, path, null, listener) | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
internalCallHandling(Request.Method.POST, path, data, listener) | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
return queue.sequenceNumber | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
internalCallHandling(Request.Method.PUT, path, data, listener) | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
Code Climate has analyzed commit 1346ba3 and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
This is a extremely basic version and is subjected to changes
Part of #194