-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test #260
Open
itbeard
wants to merge
25
commits into
itbeard/update-dotnet8
Choose a base branch
from
develop
base: itbeard/update-dotnet8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Test #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge to main
- Updated .NET version in GitHub Actions to 8.0.x. - Changed target framework in Pds.Web.csproj to net8.0. - Upgraded Blazored.LocalStorage to 4.5.0. - Updated Microsoft.AspNetCore.Components.WebAssembly packages to 8.0.8. - Upgraded AutoMapper package to 13.0.1.
- Upgraded .NET target framework from 7.0 to 8.0. - Updated GitHub Actions for both development and production to use .NET 8.0. - Modified test assertions to use fluent style in CreatePersonRequestTests and PersonServiceTest. - Updated various NuGet package references to latest versions, enhancing security and functionality: - AutoFixture to 4.18.1 - NUnit to 4.2.2 - Microsoft.NET.Test.Sdk to 17.11.1 - Autofac to 8.1.0 - Swashbuckle.AspNetCore to 6.7.3 - Microsoft.EntityFrameworkCore to 8.0.8
Update .NET7 to .NET 8
- Updated .NET SDK version from 7.0 to 8.0 in `Pds.Api` and `Pds.Web` Dockerfiles. - Ensures that the projects are built using the latest SDK features and improvements.
Update readme & dockerfile to .net 8
- Updated `.gitignore` to ignore files with `.aider*` extension. - Modified `FilterSettings` to include `From` and `To` date properties. - Enhanced `Filter.razor` component to include input fields for date range filtering. - Updated client list filtering logic in `List.razor` to support filtering by contract date range. ⭐⭐⭐⭐⭐⭐⭐⭐💩💩
- Updated `GetClientBillDto` and `GetClientsBillDto` to include the `CreatedAt` property. - Modified `IClientForBill` interface to add `CreatedAt` and `PaymentStatus` properties. - Enhanced `Bill.razor` to display `CreatedAt` based on `PaymentStatus`. - Adjusted the padding and margin in `Bill.razor.css` and `Info.razor.css` for better layout consistency. ⭐⭐⭐⭐⭐⭐⭐⭐💩💩
Changed the URL in `OnEditAsync` method to navigate to `/settings/brands/{CurrentBrand.Id}/edit` for consistency with settings structure.
…tionality - Added `@namespace Pds.Web` declaration in `App.razor` for better code organization. - Injected `Blazored.LocalStorage.ILocalStorageService` and `IJSRuntime` into `List.razor` to manage local storage. - Implemented a new button in `List.razor` to clear local storage, along with associated confirmation dialog and page reload for user feedback. - Updated the project file `Pds.Web.csproj` to include `RootNamespace` set to `Pds.Web`. ⭐⭐⭐⭐⭐⭐⭐⭐⭐💩
- Upgraded `dotnet-ef` tool version to 8.0.8 in dotnet-tools.json. - Added new `Unspecified` value to `PersonStatus` enum in Pds.Core. - Modified ApplicationDbContext to use `HasSentinel` for `PersonStatus` default value. - Replaced ef-commands.txt with ef-commands.md and included detailed EF command usage.
…s in AccessTokenResult - Updated `RequestAccessToken` and `RequestAccessToken` methods in `FakeAccessTokenProvider` to add `InteractiveRequestOptions`. - `InteractiveRequestOptions` includes `InteractionType.GetToken` and `ReturnUrl` set to "/".
…o a new property `PageSizeListValues` - Removed value validation logic from `PageSizeList` property. - Added `PageSizeListValues` property to handle the validation of `PageSizeList` values. - Updated the `OnInitialized` method to set `PageSizeListValues` from `PageSizeList`.
- Updated `DefaultPageSize`, `TotalItems`, and `Radius` to be non-nullable with default values. - Removed redundant nullable checks and default value assignments. - Ensured properties have valid values in `OnParametersSet`. - Modified `Filter.razor` to exclude unspecified person status in status filter items. ⭐⭐⭐⭐⭐⭐⭐⭐⭐⭐
…base access - Simplified and optimized LINQ queries in `BrandRepository.cs`. - Added `AsSplitQuery` for better performance in `ContentRepository.cs` and `PersonRepository.cs`. - Updated sorting logic in `DashboardRepository.cs` to order by content count. ⭐⭐⭐⭐⭐⭐⭐⭐⭐⭐
Add new documentation file `.github/docs/run.md` with commands for running code locally.
…mprove clarity on various sections including installation, Docker support, and main project settings.
- Delete old issue templates in Russian and add new English templates for bugs, features, and other issues. - Update README links to project documents to reflect new paths. - Add detailed documentation for setting up Auth0 and database. - Consolidate documentation by renaming and moving files to the docs directory.
- Upgraded Docker images for both `Pds.Api` and `Pds.Web` to use .NET 8. - Enhanced README.md: - Simplified and clarified installation and run instructions. - Consolidated content tracking features. - Improved Docker support section and feature outlines. - Refined main settings sections for frontend and backend projects. - Added new, relevant links under Useful Links. - Added `docs/code-guidelines.md` for coding and git conventions including usage of UUIDs, async naming, and branch naming practices.
Added logic to automatically assign the status "Active" to new person entries when they are created in the PersonService. This ensures that all newly added persons have a consistent initial status, facilitating further status-based operations and queries.
…of `isPagingStateHasChanged`. Updated components to accommodate changes: 1. Replaced `isPagingStateHasChanged` with `isMoveToFirstPage` across relevant files. 2. Adjusted page size array, adding smaller sizes for more flexibility. 3. Added logic to reset page offset and items count when filters change. 4. Simplified code by removing redundant statistics update functions and integrating stats updates directly within pagination handling. These changes streamline page navigation and improve user interaction by automatically starting from the first page when filters are applied. ⭐⭐⭐⭐⭐⭐⭐⭐💩💩
itbeard
commented
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seee review
@@ -41,6 +41,6 @@ public void Validate_ShouldReturnTrue() | |||
var isModelStateValid = Validator.TryValidateObject(request, context, results, true); | |||
|
|||
// assert | |||
Assert.True(isModelStateValid); | |||
Assert.That(isModelStateValid, Is.True); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dsfvdfv