Fix filtered move-on-select. #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move-on-select + filtering was broken as previously the code selected one of the filtered options. Now, as clicking on the selected option does not trigger a change event it was thus impossible to deselect that option.
|
Thanks! That resolve the bug. Summary: when moving a item from a filtered list it go to the other list and stay selected, that submitted data are false. |
|
@istvan-ujjmeszaros Please merge ... |
Cyrille37
added a commit
to Cyrille37/bootstrap-duallistbox
that referenced
this pull request
May 7, 2020
Cyrille37
added a commit
to Cyrille37/bootstrap-duallistbox
that referenced
this pull request
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move-on-select + filtering was broken as previously the code selected
one of the filtered options. Now, as clicking on the selected option
does not trigger a change event it was thus impossible to deselect that
option.