Skip to content

cue-gen: do not panic when package does not have .#1718

Merged
istio-testing merged 1 commit intoistio:masterfrom
howardjohn:cue/no-panic-missing-dot
Oct 4, 2021
Merged

cue-gen: do not panic when package does not have .#1718
istio-testing merged 1 commit intoistio:masterfrom
howardjohn:cue/no-panic-missing-dot

Conversation

@howardjohn
Copy link
Member

No description provided.

@howardjohn howardjohn requested a review from jasonwzm October 4, 2021 16:34
@howardjohn howardjohn requested a review from a team as a code owner October 4, 2021 16:34
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 4, 2021
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2021
@jasonwzm
Copy link
Member

jasonwzm commented Oct 4, 2021

Thanks for the fix! Was it locally tested?

@howardjohn
Copy link
Member Author

Thanks for the fix! Was it locally tested?

Yep

@istio-testing istio-testing merged commit 1ab29ed into istio:master Oct 4, 2021
Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this pull request Jun 30, 2022
Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants