Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push tar.gz to GCS #69

Merged
merged 2 commits into from
Feb 6, 2017
Merged

Push tar.gz to GCS #69

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04ab7ed
Push tar.gz to GCS
kyessenov Feb 6, 2017
f6211fe
Rename envoy_esp
kyessenov Feb 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions script/release-binary
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,20 @@
#
################################################################################
#
set -ex

# Make sure to this script on x86_64 Ubuntu Xenial

# The bucket name to store proxy binary
BUCKET_NAME="istio-build/proxy"

# The proxy binary name.
BINARY_FORMAT='proxy-alpha-%H'
BINARY_FORMAT='envoy-alpha-%H.tar.gz'
BINARY_NAME="$(git show -q HEAD --pretty=format:"${BINARY_FORMAT}")"

# Build the binary
bazel build --config=release //src/envoy/mixer:envoy_esp

SRC="bazel-bin/src/envoy/mixer/envoy_esp"
bazel build --config=release //src/envoy/mixer:envoy_tar
SRC="bazel-bin/src/envoy/mixer/envoy_tar.tar.gz"
DST="gs://${BUCKET_NAME}/${BINARY_NAME}"

# Copy it to the bucket.
Expand Down
12 changes: 10 additions & 2 deletions src/envoy/mixer/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
################################################################################
#

package(default_visibility = ["//visibility:public"])
load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar")

cc_library(
name = "filter_lib",
Expand All @@ -32,10 +32,18 @@ cc_library(
)

cc_binary(
name = "envoy_esp",
name = "envoy",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing the binary name to envoy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binary time is preserved in the build output. ESP is no longer included.

linkstatic = 1,
deps = [
":filter_lib",
"@envoy_git//:envoy-main",
],
)

pkg_tar(
name = "envoy_tar",
extension = "tar.gz",
files = [":envoy"],
mode = "0755",
package_dir = "/usr/local/bin/",
)