Skip to content

Commit

Permalink
add more text
Browse files Browse the repository at this point in the history
  • Loading branch information
bianpengyuan committed Jun 13, 2019
1 parent b506aa6 commit ed0ca70
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ go_rules_dependencies()

go_register_toolchains(go_version = GO_VERSION)

# TODO(bianpengyuan): remove this googleapis dep when upstream imports it in
# TODO(bianpengyuan): remove this googleapis dep when upstream envoy-wasm repo merges
# https://github.com/envoyproxy/envoy/pull/5387
load("//extensions/stackdriver/opencensus:opencensus.bzl", "telemetry_googleapis")

Expand Down
2 changes: 1 addition & 1 deletion extensions/stackdriver/opencensus/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
This folder includes opencensus library copied from <https://github.com/census-instrumentation/opencensus-cpp> with customization. Even though opencensus-cpp repo has already had bazel setup, the original code won't work out of box within a wasm sandbox or in an envoy worker silo, so we have to copy and customize it. Customization includes:

* Remove threading and thread annotations due to silo thread contrain.
* Remove assertion since it is not yet well supported by WASM runtime ABI.
* Remove assertion and stdio since they are not yet well supported by WASM VM ABI. All assertions are about checking misuse of opencensus library. It should not be a concern here since the library is used in a certain way.
* Customized stackdriver exporter using WASM sandbox gRPC API.

The library is mainly used to do data aggregation for some predefined metrics and export them to Stackdriver. The code in this directory should mostly remain unchanged unless bug is found.

0 comments on commit ed0ca70

Please sign in to comment.