Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

minor fixes in documentation. #418

Merged
merged 1 commit into from
Mar 21, 2017
Merged

minor fixes in documentation. #418

merged 1 commit into from
Mar 21, 2017

Conversation

guptasu
Copy link
Contributor

@guptasu guptasu commented Mar 20, 2017

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 20, 2017

Codecov Report

Merging #418 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
- Coverage    88.2%   88.03%   -0.18%     
==========================================
  Files          55       55              
  Lines        2824     2824              
==========================================
- Hits         2491     2486       -5     
- Misses        317      321       +4     
- Partials       16       17       +1
Impacted Files Coverage Δ
adapter/prometheus/server.go 89.47% <0%> (-10.53%) ⬇️
pkg/adapterManager/manager.go 68.53% <0%> (-2.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ec74c...c8a6c74. Read the comment docs.

@guptasu
Copy link
Contributor Author

guptasu commented Mar 20, 2017

Hi Zack,

Can you pls merge the PR, I don't seem to have required permissions.

@sebastienvas
Copy link
Contributor

build mixer/presubmit

@guptasu
Copy link
Contributor Author

guptasu commented Mar 21, 2017

How do I trigger resolve the issue ?
mixer/presubmit — Waiting for status to be reported

@sebastienvas
Copy link
Contributor

build mixer/presubmit

@geeknoid
Copy link
Contributor

geeknoid commented Mar 21, 2017 via email

@sebastienvas
Copy link
Contributor

sebastienvas commented Mar 21, 2017

Sorry, my last comment is asking Jenkins to build the presubmit. You are not part of the org so that s why it does not build it. I am trying to create a white listed group

@sebastienvas
Copy link
Contributor

jenkins please build mixer/presubmit

@istio-testing
Copy link
Contributor

Jenkins job mixer/presubmit passed

@istio-testing
Copy link
Contributor

Jenkins job manager/mixer-pr passed

@ZackButcher ZackButcher merged commit 0daa33d into istio:master Mar 21, 2017
@ZackButcher
Copy link
Contributor

Merging in for @guptasu. We should look into a bot for our repos that manages assigning reviewers and merging so these permission issues don't continue to stop people from being able to contribute.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants