Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded empty lines #9981

Merged
merged 3 commits into from
Nov 15, 2018
Merged

Conversation

linsun
Copy link
Member

@linsun linsun commented Nov 15, 2018

in helm template generated file.

@linsun linsun requested review from morvencao and ymesika and removed request for sdake and andraxylia November 15, 2018 03:00
@ymesika
Copy link
Member

ymesika commented Nov 15, 2018

/lgtm

@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #9981 into release-1.1 will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.1   #9981    +/-   ##
============================================
+ Coverage           70%     71%    +1%     
============================================
  Files              442     442            
  Lines            41223   41314    +91     
============================================
+ Hits             28739   29050   +311     
+ Misses           11083   10856   -227     
- Partials          1401    1408     +7
Impacted Files Coverage Δ
pilot/pkg/config/memory/monitor.go 82% <0%> (-9%) ⬇️
mixer/adapter/cloudwatch/cloudwatch.go 58% <0%> (-6%) ⬇️
mixer/adapter/stackdriver/stackdriver.go 50% <0%> (-4%) ⬇️
galley/pkg/crd/validation/config.go 66% <0%> (-1%) ⬇️
...ter/kubernetesenv/template/template_handler.gen.go 96% <0%> (-1%) ⬇️
mixer/pkg/protobuf/yaml/decoder.go 82% <0%> (ø) ⬇️
mixer/adapter/list/list.go 100% <0%> (ø) ⬇️
mixer/pkg/config/mcp/backend.go 72% <0%> (ø) ⬇️
mixer/adapter/kubernetesenv/cache.go 90% <0%> (ø) ⬇️
pilot/pkg/model/jwks_resolver.go 67% <0%> (ø) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e5f39...8fbb468. Read the comment docs.

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linsun, ymesika

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Collaborator

@linsun: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-multicluster-e2e.sh 8fbb468 link /test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing merged commit 190d2b5 into istio:release-1.1 Nov 15, 2018
@linsun linsun deleted the release-1.1-also branch November 16, 2018 15:05
@linsun linsun restored the release-1.1-also branch January 16, 2019 20:43
@linsun linsun deleted the release-1.1-also branch January 16, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants