Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-framework] Cleaning up test application #9413

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

nmittler
Copy link
Contributor

This is in preparation for migrating all Istio tests to use this
application.

@nmittler nmittler requested a review from ozevren October 18, 2018 19:33
@istio-testing istio-testing requested a review from costinm October 18, 2018 19:33
@nmittler nmittler removed the request for review from costinm October 18, 2018 19:33
@nmittler
Copy link
Contributor Author

nmittler commented Oct 18, 2018

@ozevren this is factored out of #9381 to simplify review and submission

@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #9413 into master will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #9413    +/-   ##
=======================================
+ Coverage      70%     70%    +1%     
=======================================
  Files         424     423     -1     
  Lines       39333   39258    -75     
=======================================
+ Hits        27333   27452   +119     
+ Misses      10701   10509   -192     
+ Partials     1299    1297     -2
Impacted Files Coverage Δ
mixer/adapter/signalfx/tracing.go 80% <0%> (-4%) ⬇️
mixer/adapter/servicecontrol/reportprocessor.go 79% <0%> (-1%) ⬇️
mixer/adapter/statsd/statsd.go 96% <0%> (-1%) ⬇️
pilot/pkg/model/validation.go 82% <0%> (ø) ⬇️
mixer/pkg/protobuf/yaml/wire/wire.go 98% <0%> (ø) ⬇️
mixer/adapter/circonus/circonus.go 71% <0%> (ø) ⬇️
mixer/template/template.gen.go 0% <0%> (ø) ⬆️
mixer/adapter/list/regexList.go 100% <0%> (ø) ⬆️
mixer/adapter/memquota/memquota.go 100% <0%> (ø) ⬆️
mixer/adapter/memquota/keys.go 100% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12fbc34...035b726. Read the comment docs.

This is in preparation for migrating all Istio tests to use this
application.
@ozevren
Copy link
Contributor

ozevren commented Oct 18, 2018

/lgtm
/approve

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: ozevren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nmittler
Copy link
Contributor Author

/test e2e-simpleTests

@nmittler
Copy link
Contributor Author

/test istio-unit-tests

@istio-testing
Copy link
Collaborator

@nmittler: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-mixer-no_auth-mcp.sh 035b726 link /test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing merged commit 35ec73e into istio:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants