Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update istio/proxy #17800

Merged
merged 4 commits into from
Oct 11, 2019
Merged

update istio/proxy #17800

merged 4 commits into from
Oct 11, 2019

Conversation

yxue
Copy link
Member

@yxue yxue commented Oct 11, 2019

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 11, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2019
@yxue
Copy link
Member Author

yxue commented Oct 11, 2019

/retest

1 similar comment
@yxue
Copy link
Member Author

yxue commented Oct 11, 2019

/retest

@yxue yxue requested a review from a team as a code owner October 11, 2019 17:58
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2019
Copy link
Contributor

@bianpengyuan bianpengyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@bianpengyuan bianpengyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yxue
Copy link
Member Author

yxue commented Oct 11, 2019

/retest

@incfly
Copy link

incfly commented Oct 11, 2019

Could you update this to 3781be0e624470a4ee613c4ffc9816976f5dd701?

istio/proxy@3781be0

@incfly
Copy link

incfly commented Oct 11, 2019

So we can incorporate @kyessenov change and transport_socket_match.

@incfly
Copy link

incfly commented Oct 11, 2019

@GregHanson @rshriram

@yxue
Copy link
Member Author

yxue commented Oct 11, 2019

/retest

@istio-testing istio-testing merged commit cf6ed77 into istio:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants