[1.1] Expose http2 window size settings as pilot env #17058
Conversation
googlebot
added
the
cla: yes
istio-testing
added
the
size/M
|
/lgtm |
| @@ -986,14 +986,24 @@ func applyUpstreamTLSSettings(env *model.Environment, cluster *apiv2.Cluster, tl | |||
| } | |||
| } | |||
|
|
|||
| func setUpstreamProtocol(cluster *apiv2.Cluster, port *model.Port) { | |||
| func setUpstreamProtocol(cluster *apiv2.Cluster, port *model.Port, proxy *model.Proxy) { | |||
There was a problem hiding this comment.
setUpstreamProtocol - proxy is unused (from unparam)
| } | ||
| i, err := strconv.Atoi(raw) | ||
| if err != nil { | ||
| log.Warnf("failed to parse PILOT_INITIAL_CONNECTION_WINDOW_SIZE: %v", err) |
There was a problem hiding this comment.
I think we should return something here, perhaps the default value. Otherwise we will end up returning whatever strconv returns in the first argument when it fails.
There was a problem hiding this comment.
This will lookup from and parse the string for each and every cluster? Can we just not cache the value?
|
and this downstream buffer limit: |
|
listener per connection buf limit is default 1MB. It might not be the one in charge of 256MB. Still looking for others |
istio-testing
added
size/L
|
/retest |
|
@howardjohn: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Thanks @howardjohn |
No description provided.