disable Access Log Service for TCP Proxy #16042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
rshriram
requested review from
andraxylia,
costinm,
diemtvu,
GregHanson,
howardjohn,
hzxuzhonghu,
nmittler,
ostromart,
vadimeisenbergibm and
ZackButcher
as code owners
googlebot
added
the
cla: yes
istio-testing
added
the
size/XS
rshriram
added
the
do-not-merge/work-in-progress
|
cc @howardjohn .. Its either something to do with the ANY or with the recent go control plane update. In my local tests, disabling ANY eliminated the validation error from Envoys. but I am not sure if something else is also going on in the background |
This reverts commit 4d55d9e.
rshriram
requested review from
linsun,
mandarjog,
morvencao and
sdake
as code owners
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
istio-testing
added
size/M
rshriram
changed the title
istio-testing
removed
the
do-not-merge/work-in-progress
|
/retest |
howardjohn
approved these changes
Aug 5, 2019
|
/retest |
|
@rshriram: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ALS is not available for TCP proxy.
Signed-off-by: Shriram Rajagopalan rshriram@tetrate.io