Skip to content

Conversation

sebastienvas
Copy link
Contributor

Update istio.Version

none

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: mandarjog

Assign the PR to them by writing /assign @mandarjog in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@sebastienvas sebastienvas requested a review from costinm October 25, 2017 18:33
@sebastienvas
Copy link
Contributor Author

/test e2e-suite-rbac-no_auth

Copy link
Contributor

@costinm costinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sebastienvas sebastienvas merged commit 651f112 into release-0.2 Oct 25, 2017
@sebastienvas sebastienvas deleted the Istio_Release_0.2.10 branch October 25, 2017 19:48
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
* ResolveHostname now uses FQDN if set.  one of destination.name or destination.service must be specified for rules.  Resolves rule matching for egress route rules and consul route rules

* fix error message in validation

* added validation tests for IstioService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants