Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api, mixerclient, proxy aren't tagged with the versions #724

Closed
ldemailly opened this issue Sep 11, 2017 · 7 comments
Closed

Api, mixerclient, proxy aren't tagged with the versions #724

ldemailly opened this issue Sep 11, 2017 · 7 comments
Assignees
Milestone

Comments

@ldemailly
Copy link
Member

@ldemailly commented on Sun Sep 10 2017

for 0.2.2 release and onward we should use the 0.2.2 api tag instead of some different shas in different children repos

if we can start by having the complete list of places referencing api that'd be good
I know of pilot/WORKSPACE - what is the complete list ?

ps: same for mixerclient and proxy

@ldemailly ldemailly changed the title Api isn't tagged with the versions Api, mixerclient, proxy aren't tagged with the versions Sep 11, 2017
@ldemailly ldemailly added this to the Istio 0.2 milestone Sep 11, 2017
@sebastienvas
Copy link
Contributor

The way this currently works this would require a new build for each repo which is not pratical. What happen if the tag that we select is different from master? The only way to make this efficiently is to use flat builds, which comes back to the same issue.

@ldemailly
Copy link
Member Author

k let's just first make sure everyone use the master sha
or tag 0.2.2 manually on api and use that tag everywhere by hand

@ldemailly
Copy link
Member Author

what is the complete list ? can we write a script that makes the updates everywhere ?

@sebastienvas
Copy link
Contributor

as of today the list is istio, mixer, pilot, auth, proxy, mixerclient, api.
mixer, pilot, auth, proxy actually provide artifacts so it should be easy to update the tool that we have to include proxy, the remaining 2 are kind of not easy to do as the mixerclient and api are barried in proxy files and as we pointed out pilot might use a different version that proxy uses etc.... I think we should limit to repo that provide artifacts

@ldemailly
Copy link
Member Author

let's try to do all as they all directly or indirectly contribute to the binaries

do you have a file list?

@sebastienvas
Copy link
Contributor

I ll automate proxy. The rest is not straightforward.

@sakshigoel12
Copy link
Contributor

not yet for mixer client. manual for now, let finish the rest after 0.2

@sakshigoel12 sakshigoel12 modified the milestones: Istio 0.2, Istio 0.3 Sep 26, 2017
mandarjog pushed a commit to mandarjog/istio that referenced this issue Oct 30, 2017
fixes istio#724

Former-commit-id: 9b8b68573f67a396aa55733fabdba6b2b2f0e5fd
mandarjog pushed a commit that referenced this issue Oct 31, 2017
kyessenov pushed a commit to kyessenov/istio that referenced this issue Aug 13, 2018
* change bucket

* do ver in advance

* debug

* del version

* del added line

* del add-on

* retest

* shorten name

* change bucket back

* reapply original change

* add OWNERS to root of proxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants