-
Notifications
You must be signed in to change notification settings - Fork 1.6k
serve Splide and Three.js locally instead of via CDN #16557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
serve Splide and Three.js locally instead of via CDN #16557
Conversation
Fixes istio#9723 Signed-off-by: Aritra Dey <adey01027@gmail.com>
Hi @AritraDey-Dev. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Aritra Dey <adey01027@gmail.com>
It's been a few years since I raised the request. Does this actually make sense? Pros of CDN: loads quicker in parallel? |
Yes, definitely makes sense. The concern you mentioned—external changes breaking the site—is actually what's causing issues when the scripts are loaded from the static folder. That’s why I’ve marked this PR as a draft for now. There are a few UI breaking changes I’m still working through. Do you recommend I continue refining the PR and eventually open it for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Description
Serve
Splide
andThree.js
locally via static directory to replace externalCDN
usage.Fixes #9723
Command run to download the css and js file -
Reviewers