Merged
Conversation
PiotrSikora
approved these changes
Aug 14, 2020
bianpengyuan
pushed a commit
to bianpengyuan/envoy
that referenced
this pull request
Apr 15, 2021
…io#259) Fixes CVE-2021-28683 (crash when peer sends an SSL Alert with an unknown code) Signed-off-by: Shikugawa <Shikugawa@gmail.com> Co-authored-by: Christoph Pakulski <christoph@tetrate.io> Signed-off-by: Tony Allen <tony@allen.gg>
istio-testing
pushed a commit
that referenced
this pull request
Apr 16, 2021
* http: Fixing empty metadata map handling (#230) #250 Commit Message: Fixing a crash when the decoder receives an empty metadata map. Additional Description: Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode. The proposed fix ignores the empty metadata maps and updates a stats if one is received. Risk Level: Medium for Envoy's running with Metadata support. Testing: Added integration tests. Docs Changes: Added a codec stats counter description. Release Notes: Added bug fix description. Platform Specific Features: N/A. Fixes a fuzz bug: 25303 Signed-off-by: Tony Allen <tony@allen.gg> * grpc: fix grpc-timeout integer overflow (#255) Fixes CVE-2021-28682, a remotely exploitable integer overflow. Signed-off-by: Asra Ali <asraa@google.com> Signed-off-by: Tony Allen <tony@allen.gg> * ssl: fix crash when peer sends an SSL Alert with an unknown code (#259) Fixes CVE-2021-28683 (crash when peer sends an SSL Alert with an unknown code) Signed-off-by: Shikugawa <Shikugawa@gmail.com> Co-authored-by: Christoph Pakulski <christoph@tetrate.io> Signed-off-by: Tony Allen <tony@allen.gg> Co-authored-by: Tony Allen <tony@allen.gg> Co-authored-by: Rei Shimizu <Shikugawa@gmail.com> Co-authored-by: Christoph Pakulski <christoph@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
manual cherry-pick of #258