Cleanup makefile #999
Cleanup makefile #999
Conversation
googlebot
added
the
cla: yes
istio-testing
added
the
size/XXL
|
|
||
| clean-mcp: | ||
| rm -f $(config_mcp_pb_gos) | ||
| rm -f $(config_mcp_pb_doc) | ||
| @rm -fr $(mcp_pb_gos) $(mcp_pb_doc) $(mcp_pb_pythons) |
There was a problem hiding this comment.
imo displaying the cmd line in make is a better practice.
There was a problem hiding this comment.
I very much dislike the pattern. I'd rather have a quiet command for normal state, and then output for failure. If you want to see more, there's a command-line option for that...
There was a problem hiding this comment.
cool - what cmd line option - didn't know that.
|
|
||
| clean-mixer: | ||
| rm -f $(mixer_v1_pb_gos) $(mixer_config_client_pb_gos) $(mixer_adapter_model_v1beta1_pb_gos) $(policy_v1beta1_pb_gos) policy/v1beta1/fixed_cfg.pb.go | ||
| rm -f $(mixer_v1_pb_doc) $(mixer_config_client_pb_doc) $(mixer_adapter_model_v1beta1_pb_doc) $(policy_v1beta1_pb_doc) | ||
| @rm -fr $(mixer_v1_pb_gos) $(mixer_v1_pb_doc) $(mixer_v1_pb_pythons) |
There was a problem hiding this comment.
definately remove the @ from all commands - makes debugging the gate easier.
There was a problem hiding this comment.
if there is a cli optino to make to output @ commands, thats cool, we should be consistent across repos on the rm stage. I'd like to keep the actual commands free of '@' related to build though.
|
I assume the container PR was somewhere modified? I'd like to take a look at that PR. |
|
PTAL. While I was in here, I incorporated the linting that was done by CircleCi into the "make lint" rule, which makes it happen via prow. So that's one more repo off of CircleCi. |
- Make more human-readable - Properly track all dependencies - Simplify container usage - Combine rules to reduce # tool invocations - Fix missing python binding for rbac protos. - Include html link checking as part of linting. - Retire CircleCi job, since that's now taken care of by the above linting change. As a result of these changes, a full rebuild takes considerably less time (1/10th maybe)
Make more human-readable
Properly track all dependencies
Simplify container usage
Combine rules to reduce # tool invocations
Fix missing python binding for rbac protos.
Include html link checking as part of linting.
Retire CircleCi job, since that's now taken care of by the above linting change.
As a result of these changes, a full rebuild takes considerably less time
(1/10th maybe)