Add traffic distribution annotation #3328
Conversation
howardjohn
added
the
release-notes-none
istio-testing
added
the
size/S
Also, the chart accidentally made it a label -- its an annotation, though. Fails until istio/api#3328
| @@ -581,3 +581,21 @@ annotations: | |||
| hidden: true | |||
| resources: | |||
| - Gateway | |||
|
|
|||
| - name: networking.istio.io/traffic-distribution | |||
There was a problem hiding this comment.
If users are setting this, should it be a label?
There was a problem hiding this comment.
make some sense, labels can be used to fiter by user
There was a problem hiding this comment.
We have labels that start with networking.istio.io (for example gatewayPort); we also have annotations that start with networking.istio.io, for example exportTo.
There was a problem hiding this comment.
I have a design to set a guidance for this: https://docs.google.com/document/d/1q27KAgIzkmqDMWI1nTMOdlBvY-dRyGTldxe9Yu3pVq0/edit.
(the doc suggests this should be an annotation)
There was a problem hiding this comment.
I've added an alternate proposal to that doc, because I prefer a criteria that's based on end-user usage and not development internals. I would suggest everyone look at that and add anything that's been missed.
This isn't a technical question at all really. It's a simple type. It could quite comfortably be either a label or an annotation, even under the proposal doc in its current state. If you think the tiebreak should be annotations, it's an annotation. If you think the tiebreak should be labels, it's a label.
Which is kinda why I'd rather go with what is maximally logical and simple to the end user.
There was a problem hiding this comment.
In the TOC meeting on monday there was some agreement to go with the proposal in the doc which would make this an annotation
There was a problem hiding this comment.
Thanks for that context, i caught up with the meeting mins and doc, SGTM
| @@ -581,3 +581,23 @@ annotations: | |||
| hidden: true | |||
| resources: | |||
| - Gateway | |||
|
|
|||
| - name: networking.istio.io/traffic-distribution | |||
There was a problem hiding this comment.
should we use same naming parttern like others, use networking.istio.io/trafficDistribution?
There was a problem hiding this comment.
It seems we are split on which we use, with most new ones using - instead of the casing.
There was a problem hiding this comment.
we should make a clear rule on this, we just introuduce some new casing annotations IIRC.
Also, the chart accidentally made it a label -- its an annotation, though. Fails until istio/api#3328
Also, the chart accidentally made it a label -- its an annotation, though. Fails until istio/api#3328
* traffic distribution: move to API repo Also, the chart accidentally made it a label -- its an annotation, though. Fails until istio/api#3328 * Rebase
Added in istio/istio#53435