support grpc configuration for opentelemetry extension provider #3301
Conversation
|
😊 Welcome @Kuromesi! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
size/M
|
Hi @Kuromesi. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks for the review! |
|
/ok-to-test |
istio-testing
added
ok-to-test
| apiVersion: release-notes/v2 | ||
| kind: feature | ||
| area: telemetry | ||
| issue: | ||
| - https://github.com/istio/istio/issues/52873 | ||
| releaseNotes: | ||
| - | | ||
| **Added** new configuration options to `OpenTelemetryTracingProvider` in `MeshConfig` to allow adding headers when exporting OpenTelemetry traces via GRPC. |
There was a problem hiding this comment.
can you remove this part here, and add it when implement it.
if you cannot implement before v1.24 came out(there's a long time), please make the API as hidden.
There was a problem hiding this comment.
Sure, I've completed the pilot coding, and it works fine on my cluster. However, I haven't finished coding the unit and integration tests yet. I believe the implementation will be done before the v1.24 release. :)
zirain
added
the
release-notes-none
|
/retest |
| // When empty, traces will check whether HTTP is set. | ||
| // If not, traces will use default GRPC configurations. |
There was a problem hiding this comment.
| // When empty, traces will check whether HTTP is set. | |
| // If not, traces will use default GRPC configurations. | |
| // When empty, traces will use the default gRPC configuration. | |
| // If `http` is set, HTTP will be used instead. |
This PR aims to support this feature request istio/istio#52873.
Add
grpcfiled in OpenTelemetryTracingProvider to support grpc headers configuration.This is quite useful when the opentelemetry endpoint get authentication information from grpc request headers, for example, Alibaba Cloud OpenTelemetry uses header
Authentication: xxxx_xxxxfor authentication.