Fix CEL validation on older k8s versions #3219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
istio-testing
added
the
size/M
Also add testing so we can catch this (though its tied to a single k8s version, so its not perfect -- but should be able to catch most cases). CEL before k8s 1.30 did not estimate the cost correctly so its basically impossible
|
I have a better fix in progress (allowing us to keep the rule), happy to wait or merge as-is in the meantime |
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
howardjohn
added a commit
to howardjohn/tools
that referenced
this pull request
May 30, 2024
howardjohn
added a commit
to howardjohn/tools
that referenced
this pull request
May 30, 2024
istio-testing
pushed a commit
to istio/tools
that referenced
this pull request
May 30, 2024
|
Will this fix this error? |
|
yes |
|
/retest |
ericvn
approved these changes
May 31, 2024
jwendell
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add testing so we can catch this (though its tied to a single k8s
version, so its not perfect -- but should be able to catch most cases).
CEL before k8s 1.30 did not estimate the cost correctly so its basically
impossible