Remove mention of REPLACE operation for EXTENSION_CONFIG EnvoyFilter #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
istio-testing
added
the
size/XS
leosarra
added
the
release-notes-none
|
/retest |
hzxuzhonghu
approved these changes
Jan 16, 2024
zirain
approved these changes
Jan 16, 2024
kfaseela
approved these changes
Jan 16, 2024
howardjohn
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3034
We are currently mentioning support for a REPLACE operation on extenion_configs in a comment inside the proto file.
But EnvoyFilter patching of extenion_config only supports ADD operation as shown here
https://github.com/istio/istio/blob/master/pilot/pkg/networking/core/v1alpha3/envoyfilter/extension_configuration_patch.go#L35
As stated elsewhere in our documentation: "REPLACE operation is only valid for HTTP_FILTER and NETWORK_FILTER. If the named filter is not found, this operation has no effect".