Skip to content

Add istiod remote to component proto #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 12, 2020
Merged

Add istiod remote to component proto #1428

merged 9 commits into from
May 12, 2020

Conversation

linsun
Copy link
Member

@linsun linsun commented May 11, 2020 •
edited
Loading

related to istio/istio#23716

@istio-policy-bot
Copy link

😊 Welcome @linsun! This is either your first contribution to the Istio api repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 11, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2020
@linsun
Copy link
Member Author

linsun commented May 11, 2020

/test gencheck_api

@linsun linsun mentioned this pull request May 11, 2020
Closed
rshriram
rshriram reviewed May 11, 2020
View reviewed changes
dcberg
dcberg reviewed May 11, 2020
View reviewed changes
dcberg
dcberg reviewed May 11, 2020
View reviewed changes
dcberg
dcberg reviewed May 11, 2020
View reviewed changes
dcberg
dcberg previously requested changes May 11, 2020
View reviewed changes
Copy link

@dcberg dcberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend changes to keep consistent with camel case and using an underscore in the porto name (see inline comments).

@linsun
Copy link
Member Author

linsun commented May 11, 2020

@dcberg I have updated and regenerated all files. Thanks!

@linsun linsun dismissed dcberg’s stale review May 12, 2020 01:08

addressed already

@istio-testing istio-testing merged commit 83e5c7a into istio:master May 12, 2020
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: #1428 failed to apply on top of branch "release-1.6":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	CODEOWNERS
Falling back to patching base and 3-way merge...
Auto-merging CODEOWNERS
CONFLICT (content): Merge conflict in CODEOWNERS
Patch failed at 0001 update to individual owners

@istio-testing istio-testing mentioned this pull request May 12, 2020
Closed
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new issue created for failed cherrypick: #1431

istio-testing pushed a commit that referenced this pull request May 12, 2020
@linsun
[release-1.6] cherry-pick Add istiod remote to component proto #1428 (#…
8897969 
…1432)

* update

* cherry pick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duderino duderino Awaiting requested review from duderino

@louiscryan louiscryan Awaiting requested review from louiscryan

@smawson smawson Awaiting requested review from smawson

3 more reviewers

@rshriram rshriram rshriram approved these changes

@ostromart ostromart ostromart approved these changes

@dcberg dcberg dcberg left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@linsun @istio-policy-bot @istio-testing @dcberg @rshriram @ostromart @googlebot