Adding ClusterLocalNamespaces to mesh config #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmittler
requested review from
dcberg,
duderino,
linsun,
louiscryan,
rshriram and
smawson
as code owners
|
😊 Welcome @nmittler! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
googlebot
added
the
cla: yes
istio-testing
added
the
size/XS
istio-testing
added
size/S
smawson
reviewed
Mar 30, 2020
This is currently kept as a hidden/undocumented property
smawson
approved these changes
Mar 30, 2020
|
Why do we need another field in the mesh config? We have the exportTo setting. users can add an annotation to the namespaces indicating what is and what is not exported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently kept as a hidden/undocumented property