Skip to content

fix destination rule ttl mismatched type #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2020
Merged

fix destination rule ttl mismatched type #1285

merged 1 commit into from
Feb 18, 2020

Conversation

kentchenjh
Copy link
Contributor

related to #1269

@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 12, 2020
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 12, 2020
@istio-testing
Copy link
Collaborator

Hi @kentchenjh. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rshriram
Copy link
Member

You will have to send a PR to istio/istio to ensure that the ttl is properly processed. Removing the gogo stdduration will require us to fix the go structs in pilot code that sets up the TTL

@rshriram
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Feb 12, 2020
@rshriram
Copy link
Member

Once you send that PR, happy to approve this as well.

@kentchenjh kentchenjh mentioned this pull request Feb 13, 2020
Merged
@kentchenjh
Copy link
Contributor Author

already send a PR,
check istio/istio#21101

@istio-testing istio-testing merged commit 7fd43ea into istio:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@ramaraochavali ramaraochavali ramaraochavali approved these changes

@dcberg dcberg Awaiting requested review from dcberg

@geeknoid geeknoid Awaiting requested review from geeknoid

@linsun linsun Awaiting requested review from linsun

@louiscryan louiscryan Awaiting requested review from louiscryan

@smawson smawson Awaiting requested review from smawson

+1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kentchenjh @istio-policy-bot @istio-testing @rshriram @hzxuzhonghu @ramaraochavali @googlebot