Skip to content

Automator: update common-files@master in istio/api@master #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2020
Merged

Automator: update common-files@master in istio/api@master #1271

merged 1 commit into from
Feb 22, 2020

Conversation

istio-testing
Copy link
Collaborator

@istio-testing istio-testing commented Feb 5, 2020 •
edited
Loading

Generated by Automator - 2020-02-22T03:40:30+00:00

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 5, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2020
@clarketm clarketm mentioned this pull request Feb 6, 2020
Merged
@clarketm
Copy link
Member

clarketm commented Feb 6, 2020 •
edited
Loading

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
gencheck_api 504dd39 link /test gencheck_api

The culprit here looks like a stale container image on the job: istio/test-infra#2348

@clarketm clarketm added the do-not-merge/hold Block automatic merging of a PR. label Feb 6, 2020
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2020
@istio-testing istio-testing force-pushed the master-commonfiles branch 2 times, most recently from 5654039 to 085664d Compare February 13, 2020 15:28
@clarketm clarketm removed the do-not-merge/hold Block automatic merging of a PR. label Feb 13, 2020
@istio-testing istio-testing force-pushed the master-commonfiles branch 2 times, most recently from 7f0b970 to 8652b1f Compare February 20, 2020 19:22
@istio-testing istio-testing added the auto-merge Set this label on a PR to auto-merge it on success of presubmit tests label Feb 22, 2020
@istio-testing istio-testing merged commit b245c55 into istio:master Feb 22, 2020
@clarketm clarketm mentioned this pull request Feb 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcberg dcberg Awaiting requested review from dcberg

@geeknoid geeknoid Awaiting requested review from geeknoid

@linsun linsun Awaiting requested review from linsun

@louiscryan louiscryan Awaiting requested review from louiscryan

@rshriram rshriram Awaiting requested review from rshriram

@smawson smawson Awaiting requested review from smawson

1 more reviewer

@clarketm clarketm clarketm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
auto-merge Set this label on a PR to auto-merge it on success of presubmit tests cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@istio-testing @clarketm @googlebot