Add json codegen for Operator #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkleeman
requested review from
dcberg,
geeknoid,
linsun,
louiscryan,
rshriram,
smawson and
a team
as code owners
googlebot
added
the
cla: yes
istio-testing
added
the
size/S
jackkleeman
force-pushed
the
operator-jsongen
branch
2 times, most recently
from
a8e4f63 to
ccf1091
Compare
jasonwzm
approved these changes
Jan 30, 2020
rshriram
approved these changes
Jan 31, 2020
|
/retest |
jackkleeman
force-pushed
the
operator-jsongen
branch
from
ccf1091 to
06c9756
Compare
We have a pretty nasty bug where fields with two names, eg UnvalidatedValues, aren't getting unmarshaled properly in k8s clients because we haven't set up jsonpb unmarshaling for the Operator. This should solve it.
jackkleeman
force-pushed
the
operator-jsongen
branch
from
06c9756 to
db8e01c
Compare
|
Had to do some pretty dodgy stuff in the makefile because our GOTYPE annotations don't place nice with json codegen |
ericvn
approved these changes
Feb 3, 2020
|
In response to a cherrypick label: new pull request created: #1307 |
|
This is needed for release-1.5 to fix: istio/istio#21554 /cc @ostromart @dgn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a pretty nasty bug where fields with two names, eg
UnvalidatedValues, aren't getting unmarshaled properly in k8s clients
because we haven't set up jsonpb unmarshaling for the Operator. This
should solve it.