Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of http retry priority #1156

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Add support of http retry priority #1156

merged 1 commit into from
Feb 11, 2020

Conversation

ckcd
Copy link
Contributor

@ckcd ckcd commented Nov 4, 2019

Add parameter for envoy.retry_priorities.previous_priorities in retry_priority.

See https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/http/http_connection_management#arch-overview-http-retry-plugins

related issue: istio/istio#18418

@ckcd ckcd requested a review from a team as a code owner November 4, 2019 07:07
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 4, 2019
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Nov 4, 2019
@istio-testing
Copy link
Collaborator

Hi @ckcd. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ckcd ckcd changed the title add support of http retry priority Add support of http retry priority Nov 4, 2019
@ckcd
Copy link
Contributor Author

ckcd commented Nov 4, 2019

/assign @howardjohn
/assign @rshriram

@ckcd
Copy link
Contributor Author

ckcd commented Nov 6, 2019

Seems like we need a ok-to-test label. @howardjohn

@istio-testing
Copy link
Collaborator

@ckcd: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn
Copy link
Member

howardjohn commented Nov 6, 2019 via email

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 6, 2019
@ckcd
Copy link
Contributor Author

ckcd commented Nov 9, 2019

@howardjohn Can we merge this ? Thanks.

@howardjohn
Copy link
Member

this still needs approval from @rshriram

@ckcd
Copy link
Contributor Author

ckcd commented Nov 13, 2019

@rshriram PTAL.

@ckcd
Copy link
Contributor Author

ckcd commented Nov 22, 2019

@rshriram Please take a look, thanks a lot~

rshriram
rshriram reviewed Nov 22, 2019
View reviewed changes
Copy link
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..

networking/v1alpha3/virtual_service.proto Outdated Show resolved Hide resolved
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2019
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2019
@ckcd
Copy link
Contributor Author

ckcd commented Nov 26, 2019

push again to solve conflict.

@ckcd ckcd requested a review from rshriram November 27, 2019 03:44
@ckcd
Copy link
Contributor Author

ckcd commented Dec 2, 2019

Any changes should I do ? @howardjohn @rshriram

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 8, 2020
@ckcd ckcd changed the title Add support of http retry priority [WIP] Add support of http retry priority Jan 8, 2020
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 8, 2020
@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2020
@ckcd ckcd changed the title [WIP] Add support of http retry priority Add support of http retry priority Jan 8, 2020
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 8, 2020
rshriram
rshriram reviewed Jan 8, 2020
View reviewed changes
networking/v1alpha3/virtual_service.proto Outdated

// Flag to specify whether the retries should retry to other localities.
// See the [retry plugin configuration](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/http/http_connection_management#retry-plugin-configuration) for more details.
bool retry_remote_localities = 4;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a wrapper so that we can have defaults? Otherwise, it will always default to false even if we want to default it to true in future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do the convert.

@rshriram
Copy link
Member

rshriram commented Jan 8, 2020

can you convert it to a wrapper please?

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 9, 2020
@ckcd
Copy link
Contributor Author

ckcd commented Jan 9, 2020

can you convert it to a wrapper please?

Done~ PTAL. @rshriram

thanks !

@ckcd ckcd requested a review from rshriram January 13, 2020 12:12
@howardjohn
Copy link
Member

@ckcd this just needs a rebase

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2020
@istio-testing istio-testing merged commit 251e511 into istio:master Feb 11, 2020
@ckcd ckcd mentioned this pull request Mar 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu left review comments

@howardjohn howardjohn howardjohn approved these changes

@rshriram rshriram rshriram approved these changes

@dcberg dcberg Awaiting requested review from dcberg

@geeknoid geeknoid Awaiting requested review from geeknoid

@linsun linsun Awaiting requested review from linsun

@louiscryan louiscryan Awaiting requested review from louiscryan

@smawson smawson Awaiting requested review from smawson

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ckcd @istio-testing @howardjohn @rshriram @hzxuzhonghu @googlebot