Add WorkloadSelector definition in a common directory.

[liminw]

No description provided.

[yangminzhu]

I think this needs to be tab instead of whitespaces.

[liminw]

Done.

[yangminzhu]

If you want to hide the doc, I think you also need $hide_from_docs here.

[liminw]

Done.

[rshriram]

Can you also update the EnvoyFilter to use this workload selector [and update the comments in envoyfilter accordingly] ? The workloadSelector there has not been released yet.
There is a workloadSelector in the Sidecar.proto.. Please remove it and make the sidecar refer to this. Since the sidecar uses workloadSelector.labels, i suggest you add a labels field in this proto and mark it as deprecated.
In the implementation, its as simple as copying the value from the existing labels field into the new matchLabels field.

[liminw]

I will do EnvoyFilter/Sidecar proto change in a separate PR.

[yangminzhu]

I think it's better to use perFile

[liminw]

Done.

[costinm]

Do we have a plan to migrate the other selectors to this ? Is it identical with any of the in-use selectors ? Did the TOC agree to deprecate the 3 selector APIs and switch to this one ( or to have 4 selector methods ) ? I would really like to see an official TOC review and decision on the deprecation or migration to new selector.

…

On Fri, Aug 9, 2019 at 5:19 PM Limin Wang ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Makefile.core.mk <#1032 (comment)>: > ##################### # Generation Rules ##################### generate: \ + generate-type \ Done. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1032?email_source=notifications&email_token=AAAUR2TN3MLZ47TBKCCYBULQDYCQRA5CNFSM4IKYBHK2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCBF4KLQ#discussion_r312681088>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAUR2SEYFDNBSVRPSJX7SDQDYCQRANCNFSM4IKYBHKQ> .

[liminw]

@costinm I think there is consensus we need a common "selector" definition. This PR just added one following Istio Config Model.
The existing selector definitions are already different.

In sidecar

workloadSelector:
   labels:
      app: A

In Gateway,

selector:
   app: A

As @rshriram commented in this PR, if we choose consistency, some form of deprecation cannot be avoided.

I don't care too much about the exact naming, as long as there is consensus. Since we are introducing beta API now, I think it is important to make sure API stability and consistency.

@louiscryan Any recommendation?

[rshriram]

no hide from docs if this is going to be used by Sidecar/envoyfilter etc.

[liminw]

Done.