Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing docs #351

Closed
geeknoid opened this issue Feb 2, 2018 · 0 comments
Closed

Add missing docs #351

geeknoid opened this issue Feb 2, 2018 · 0 comments

Comments

@geeknoid
Copy link
Contributor

geeknoid commented Feb 2, 2018

no comment found for istio.mixer.v1
mixer/v1/attributes.proto:76:6: no comment found for string_value
mixer/v1/attributes.proto:77:6: no comment found for int64_value
mixer/v1/attributes.proto:78:6: no comment found for double_value
mixer/v1/attributes.proto:79:6: no comment found for bool_value
mixer/v1/attributes.proto:80:6: no comment found for bytes_value
mixer/v1/attributes.proto:81:6: no comment found for timestamp_value
mixer/v1/attributes.proto:82:6: no comment found for duration_value
mixer/v1/attributes.proto:83:6: no comment found for string_map_value
mixer/v1/attributes.proto:89:4: no comment found for entries
mixer/v1/check.proto:59:0: no comment found for CheckResponse
mixer/v1/check.proto:60:2: no comment found for PreconditionResult
mixer/v1/check.proto:84:2: no comment found for QuotaResult
mixer/v1/attributes.proto:109:2: no comment found for int64s
mixer/v1/attributes.proto:110:2: no comment found for doubles
mixer/v1/attributes.proto:111:2: no comment found for bools
mixer/v1/attributes.proto:112:2: no comment found for timestamps
mixer/v1/attributes.proto:113:2: no comment found for durations
mixer/v1/attributes.proto:114:2: no comment found for bytes
mixer/v1/attributes.proto:115:2: no comment found for string_maps
mixer/v1/check.proto:115:2: no comment found for AttributeMatch
mixer/v1/report.proto:60:0: no comment found for ReportResponse
mixer/v1/attributes.proto:121:2: no comment found for entries

@geeknoid geeknoid self-assigned this Feb 2, 2018
@geeknoid geeknoid added this to the 1.0 milestone Jun 13, 2018
incfly pushed a commit to incfly/api that referenced this issue Jun 13, 2018
* Provide an envoy timer for mixer client.

* change timer class.

* Update mixer client sha.
@geeknoid geeknoid assigned kyessenov and unassigned geeknoid Aug 17, 2019
nacx pushed a commit to nacx/api that referenced this issue Feb 23, 2022
Update ext-auth backend now support gRPC server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants