Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

istio/api needs a build #249

Closed
andraxylia opened this issue Nov 21, 2017 · 0 comments
Closed

istio/api needs a build #249

andraxylia opened this issue Nov 21, 2017 · 0 comments
Labels
community/help wanted Indicates a PR/Issue that needs community help
Milestone
Istio 0.3

Comments

@andraxylia
Copy link
Contributor

andraxylia commented Nov 21, 2017 •
edited
Loading

Anything can be committed in a proto file and there is no validation this builds until istio/istio is built.

istio/api needs a bazel build because it needs to compile the proto files.

On top of this, the build can run scripts/generate-protos.sh to update the generated files.
@andraxylia andraxylia added this to the Istio 0.3 milestone Nov 21, 2017
@andraxylia andraxylia added the community/help wanted Indicates a PR/Issue that needs community help label Nov 21, 2017
@ZackButcher ZackButcher mentioned this issue Nov 21, 2017
Merged
incfly pushed a commit to incfly/api that referenced this issue Jun 13, 2018
@qiwzhang
Copy path matcher code over for api_spec. (istio#249)
775290a 
* Copy path matcher code over for api_spec.

* fixed asan test failure.
nacx added a commit to nacx/api that referenced this issue Feb 23, 2022
@nacx
Remove incorrect Role validation (istio#249)
0a08a02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community/help wanted Indicates a PR/Issue that needs community help
Projects
None yet
Milestone
Istio 0.3
Development

No branches or pull requests
1 participant
@andraxylia