Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"set of criteria" in docs/reference/config/networking/virtual-service/index.html #1931

Closed
dsbos opened this issue Mar 29, 2021 · 2 comments · Fixed by #3195
Closed

"set of criteria" in docs/reference/config/networking/virtual-service/index.html #1931

dsbos opened this issue Mar 29, 2021 · 2 comments · Fixed by #3195
Assignees
@howardjohn
Labels
area/networking lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically.

Comments

@dsbos
Copy link

dsbos commented Mar 29, 2021

"set of criterion" should be "set of criteria"
("criteria" is plural, "criterion" is singular)
@ericvn
Copy link

ericvn commented Mar 29, 2021

Needs to be updated here: https://github.com/istio/api/blob/master/networking/v1alpha3/virtual_service.proto#L940 and cherry-picked to release-1.9 branch.

@ericvn ericvn transferred this issue from istio/istio.io Mar 29, 2021
@howardjohn howardjohn self-assigned this May 14, 2024
@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label May 14, 2024
howardjohn added a commit to howardjohn/api that referenced this issue May 14, 2024
@howardjohn
virtual service: minor grammar fix
02bd446 
Fixes istio#1931
@howardjohn howardjohn mentioned this issue May 14, 2024
Merged
@howardjohn
Copy link
Member

#3195

@howardjohn howardjohn reopened this May 14, 2024
istio-testing pushed a commit that referenced this issue May 20, 2024
@howardjohn
virtual service: minor grammar fix (#3195)
e68bd5f 
Fixes #1931
istio-testing pushed a commit to istio-testing/api that referenced this issue May 20, 2024
@howardjohn @istio-testing
virtual service: minor grammar fix
d9cd963 
Fixes istio#1931
istio-testing added a commit that referenced this issue Jul 2, 2024
@istio-testing @howardjohn
virtual service: minor grammar fix (#3205)
b04e0a6 
Fixes #1931

Co-authored-by: John Howard <john.howard@solo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@howardjohn howardjohn

Labels
area/networking lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

virtual service: minor grammar fix howardjohn/api
4 participants
@howardjohn @dsbos @ericvn @istio-policy-bot