Skip to content

Commit

Permalink
Add missing quotes for the sample snippet in tracespan template (isti…
Browse files Browse the repository at this point in the history
  • Loading branch information
morningspace authored and istio-testing committed Aug 3, 2019
1 parent 8757a56 commit 7845e7e
Show file tree
Hide file tree
Showing 8 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion mixer/template/tracespan/traceSpan.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion mixer/template/tracespan/tracespan.proto
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ syntax = "proto3";
// startTime: request.time
// endTime: response.time
// clientSpan: (context.reporter.kind | "inbound") == "outbound"
// rewriteClientSpanId: false
// rewriteClientSpanId: "false"
// spanTags:
// http.method: request.method | ""
// http.status_code: response.code | 200
Expand Down
2 changes: 1 addition & 1 deletion mixer/template/tracespan/tracespan.yaml

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion mixer/template/tracespan/tracespan_handler.gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ import (
// startTime: request.time
// endTime: response.time
// clientSpan: (context.reporter.kind | "inbound") == "outbound"
// rewriteClientSpanId: false
// rewriteClientSpanId: "false"
// spanTags:
// http.method: request.method | ""
// http.status_code: response.code | 200
Expand Down
Binary file not shown.
2 changes: 1 addition & 1 deletion mixer/template/tracespan/tracespan_handler_service.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion mixer/template/tracespan/tracespan_handler_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ syntax = "proto3";
// startTime: request.time
// endTime: response.time
// clientSpan: (context.reporter.kind | "inbound") == "outbound"
// rewriteClientSpanId: false
// rewriteClientSpanId: "false"
// spanTags:
// http.method: request.method | ""
// http.status_code: response.code | 200
Expand Down
Binary file modified mixer/template/tracespan/tracespan_proto.descriptor_set
Binary file not shown.

0 comments on commit 7845e7e

Please sign in to comment.