Skip to content

[BUG] CRD validation and duplication on various configuration items #665

Open
@michaelalang

Description

Is this the right place to submit this?

  • This is not a question about how to use the sail-operator

Bug Description

I recently started to lookin into migration to Sail operator and found various duplicated CRD definitions for items like:

  values:
    global:
       meshID      <string>
 ---
  values:  
    meshConfig:
      defaultConfig:
        meshId:      <string>

without any explanation which one should be used .

Furthermore the Operator doesn't seem to handle misalignment of configuration items in the CR correctly, like
injecting

apiVersion: sailoperator.io/v1alpha1
kind: Istio
metadata:
  name: east
spec:
  namespace: istio-system
  updateStrategy:
    inactiveRevisionDeletionGracePeriodSeconds: 30
    type: RevisionBased
  version: v1.24.1
  values:
    global:
      meshID: east
  meshConfig:   # <<< misaligned should be within `values`
    accessLogFormat: json
    defaultConfig:
      meshId: west

is not reported but silently ignored.
Can someone explain the duplication and are we going to fix the validation ?

Operator Version

0.2

Link to Gist with Logs

No response

Additional Information

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions