Fix race in monitor test #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndreasDahl, could you review the changes here? Its confirmed to fix the problems observed in #128, and the change is benign (only changes a test and since it passes tests, we should be good). |
AndreasDahl
approved these changes
Oct 24, 2023
|
Looks good to me. @andersfugmann Will you create a release? |
|
Thanks for the review. I'll create a new release. |
andersfugmann
added a commit
to andersfugmann/opam-repository
that referenced
this pull request
Oct 26, 2023
CHANGES: * Fix race in monitor test (issuu/ocaml-zmq#129, @andersfugmann)
|
Release pending: ocaml/opam-repository#24688 |
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: * Fix race in monitor test (issuu/ocaml-zmq#129, @andersfugmann)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #128