Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize exception list with zmq.h #10

Merged
merged 1 commit into from
Apr 22, 2014
Merged

Synchronize exception list with zmq.h #10

merged 1 commit into from
Apr 22, 2014

Conversation

whitequark
Copy link
Contributor

No description provided.

@jj-issuu
Copy link
Contributor

Thanks for the pull request. The merge might have to wait until next week because of Easter holidays.

@whitequark
Copy link
Contributor Author

While we're at it, there's been some discussion on IRC--apparently an ocaml-zmq release is needed for people to be able to conveniently use iocaml. So please take a look at that, too.

@andersfugmann
Copy link
Contributor

Looks fine to me

andersfugmann added a commit that referenced this pull request Apr 22, 2014
Synchronize exception list with zmq.h
@andersfugmann andersfugmann merged commit 55df097 into issuu:master Apr 22, 2014
@andrewray
Copy link
Contributor

This removes EAGAIN and EINTR both of which are error codes used in lwt-zmq.

A different reading of the zmq.h header file is that it's all posix error codes (or Unix.error) + 4 special 0MQ ones (along with some hackery to make windows work).

@whitequark
Copy link
Contributor Author

@andrewray EAGAIN and EINTR will be raised as Unix.Unix_error.

@andrewray
Copy link
Contributor

Ahah...that makes perfect sense.

On Wed, Apr 23, 2014 at 4:22 PM, Peter Zotov notifications@github.comwrote:

@andrewray https://github.com/andrewray EAGAIN and EINTR will be raised
as Unix.Unix_error.


Reply to this email directly or view it on GitHubhttps://github.com//pull/10#issuecomment-41174330
.

@andrewray
Copy link
Contributor

I seem to be getting:

ZMQ.ZMQ_exception(22, "Resource temporarily unavailable")

Rather than

Unix.Unix_error (Unix.EAGAIN, _, _)

Possibly suspicious that EAGAIN=11 and I'm seeing 22?

@whitequark
Copy link
Contributor Author

@andrewray My fault. I'll send a PR later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants