isso: html.py: Prevent auto creation of invalid links in comments #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelmer
approved these changes
Mar 10, 2024
jelmer
requested changes
Mar 10, 2024
|
also, please complete the checklist in the PR template |
pkvach
changed the title
|
Added an entry to CHANGES.rst |
|
Fixed linting issues. |
jelmer
approved these changes
Mar 10, 2024
|
Sorry for the late reply, thank you @pkvach for this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
What changes does this Pull Request introduce?
Enhanced the
Sanitizerclass inisso/utils/html.pyto prevent the automatic creation of invalid links by:modifying the
set_linksfunction to reject new links, allowing only existing links to be modified. This change addresses the issue where text could be misinterpreted as a domain name, leading to the creation of invalid links.Updated tests in
isso/tests/test_html.pyto include new cases that ensure:text that could be misinterpreted as links, such as 'ld.so' and file paths, are not automatically converted into links.
Why is this necessary?
Fixes #557