JS: Minor jest-puppeteer test fix, update Javascript dev dependencies #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ix5
added
client
The previous `toMatch()` method does not work any more. See argos-ci/jest-puppeteer#535
Quotation marks and others are no longer string-escaped in Jest 29. See https://jestjs.io/blog/2022/08/25/jest-29
No noticeable visual changes, presumably due to font or other rendering engine changes in the base image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.rstbecause this is a user-facing change or an important bugfixWhat changes does this Pull Request introduce?
Minor update in the JS integration tests as well as bumping javascript dependency versions.
Why is this necessary?
The
.toMatch()function for thejest-puppeteerintegration tests is no longer supported, see argos-ci/jest-puppeteer#535