Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Spanish translation for clarity and consistency #967

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Improve Spanish translation for clarity and consistency #967

merged 2 commits into from
Aug 17, 2023

Conversation

welpo
Copy link
Contributor

@welpo welpo commented Aug 17, 2023

Checklist

  • All new and existing tests are passing
  • (If adding features:) I have added tests to cover my changes
  • (If docs changes needed:) I have updated the documentation accordingly.
  • I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
  • I have written proper commit message(s)

What changes does this Pull Request introduce?

Updates the Spanish translation in the following ways:

  • Harmonises and corrects capitalisation for consistency. Spanish doesn't capitalise each word in a title.

  • Adds translations for new placeholders.

  • Shifts from formal to informal tone for user-friendliness. It's also the standard for documentation.

  • Replaces some translations to make them more natural.

  • Makes use of singular/plural strings for comment-hidden.

Why is this necessary?

Better user experience for Spanish speakers.

- Harmonise and correct capitalisation for consistency.
Spanish doesn't capitalise each word in a title.

- Add translations for new placeholders.

- Shift from formal to informal tone for user-friendliness.

- Replace some translations to make them more natural.

- Make use of singular/plural strings for `comment-hidden`.
@ix5
Copy link
Member

ix5 commented Aug 17, 2023

LGTM, I agree with the informal tone as well.

Thank you for your contribution!

@ix5 ix5 merged commit e54971b into isso-comments:master Aug 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants