Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Include more information, new screenshot #867

Merged
merged 1 commit into from
May 7, 2022

Conversation

ix5
Copy link
Member

@ix5 ix5 commented May 7, 2022

Add more sections, with more links, small install guide, add new screenshot.

This should make the README more inviting to people browsing GH - and also PyPI, as the README is also automatically uploaded there.

Live preview @ TestPyPI

Screenshot used:
screenshot

Add more sections, with more links, small install guide, add
new screenshot.

This should make the README more inviting to people browsing
GH - and also PyPI, as the README is also automatically
uploaded there.
@ix5 ix5 added docs Documentation of the project meta Concerning the general direction and organisation of the project improvement Not a new feature, but makes Isso more pleasant to use labels May 7, 2022
@ix5 ix5 added this to the 0.13 milestone May 7, 2022
@ix5 ix5 merged commit 05ba602 into isso-comments:master May 7, 2022
@ix5 ix5 deleted the readme-extend branch May 7, 2022 19:59
@ix5 ix5 mentioned this pull request May 25, 2022
38 tasks
## Geting started

**Requirements**
- Python 3.6+ (+ devel headers)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need devel headers or a C compiler? @ix5

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a copy-paste from the docs. Probably necessary for misaka and CFFI things?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you were also the one who added it to the docs in 93d05c4

I don't think we need C headers for something that's CFFI.

Copy link
Member Author

@ix5 ix5 Dec 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devel headers were added way back in d1a0b3f6, I just happen to show up in the blame logs because I bumped versions a couple of times and moved files ;)

As for the validity, maybe we ought to collect empirical data by removing devel headers from our respective systems and seeing whether a full installation in a clean virtualenv (including misaka CFFI compilation) still works.

## Geting started

**Requirements**
- Python 3.6+ (+ devel headers)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you were also the one who added it to the docs in 93d05c4

I don't think we need C headers for something that's CFFI.


**Requirements**
- Python 3.6+ (+ devel headers)
- SQLite 3.3.8 or later
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQLite3 is bundled with python, isn't it? You don't really need the command-line tool.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for the devel headers, let's verify and then I'm not at all opposed to removing those docs lines.

@ix5 ix5 mentioned this pull request Jun 20, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation of the project improvement Not a new feature, but makes Isso more pleasant to use meta Concerning the general direction and organisation of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants