Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing error message: URI {uri} does not exist #1036

Merged

Conversation

Lucas-C
Copy link
Contributor

@Lucas-C Lucas-C commented Sep 16, 2024

Checklist

  • All new and existing tests are passing
  • [NA] (If adding features:) I have added tests to cover my changes
  • [NA] (If docs changes needed:) I have updated the documentation accordingly.
  • [NA] I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
  • I have written proper commit message(s)

What changes does this Pull Request introduce?

Previous to this one-line fix, the following error message could be returned:

URI does not exist %s

Now the error message containes the actual URI:

URI {uri} does not exist

Why is this necessary?

To help debug problems! 🙂

@jelmer
Copy link
Member

jelmer commented Sep 16, 2024

The change overall LGTM, thanks!

@jelmer
Copy link
Member

jelmer commented Sep 17, 2024

What's going on with the failing e2e test?

@Lucas-C
Copy link
Contributor Author

Lucas-C commented Sep 30, 2024

Seems like the CI pipeline fails due to "screenshots not matching".

But this PR should not have any visual impact.

Maybe the reference screenshots should be updated in a separate PR?
The process is detailed in this documentation section: https://github.com/isso-comments/isso/blob/master/docs/docs/technical-docs/testing-client.rst#screenshot-comparison

@jelmer jelmer self-requested a review October 1, 2024 21:33
@jelmer jelmer merged commit 15b32da into isso-comments:master Oct 1, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants