Add content visibility change handler for video grid#39
Merged
issackjohn merged 2 commits intoresponsive-designfrom Aug 18, 2025
Merged
Add content visibility change handler for video grid#39issackjohn merged 2 commits intoresponsive-designfrom
issackjohn merged 2 commits intoresponsive-designfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR performs various cleanup tasks across the codebase including removing unused code, simplifying methods, and adding event handling for content visibility.
- Removes unused
getContentDocument()method and simplifies thelayout()method signature - Changes
wrapElement()from public to private method by renaming to_wrapElement() - Adds content visibility event handling to video grid component and corresponding test infrastructure
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| resources/tests.mjs | Adds event listener for video grid content visibility completion in test |
| resources/benchmark-runner.mjs | Removes unused method, simplifies layout method, and makes wrapElement private |
| experimental/responsive-design/src/lib/components/video-grid.js | Adds content visibility change event handler and dispatcher |
| experimental/responsive-design/src/lib/components/article-grid.js | Adds blank line for formatting consistency |
| experimental/responsive-design/index.html | Changes overflow CSS from hidden to auto |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
issackjohn
added a commit
that referenced
this pull request
Aug 25, 2025
* remove extra changes * Add content visibility change handlers for video grid
issackjohn
added a commit
that referenced
this pull request
Dec 23, 2025
* remove extra changes * Add content visibility change handlers for video grid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.